Modify 'Must be attached' error to be more descriptive #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it outputs a more descriptive version: `${event} event triggerd with ${selector} on ${templateName} but associated view is not be found.
Make sure the event doesn't destroy the view.`
Fixes meteor#213
|
cc @jankapunkt @StorytellerCZ |
jankapunkt
requested changes
Jun 19, 2022
packages/blaze/domrange.js
Outdated
| @@ -332,9 +332,11 @@ DOMRange.prototype.destroy = function (_skipNodes) { | |||
| DOMRange._destroy(this, _skipNodes); | |||
| }; | |||
|
|
|||
| DOMRange.prototype.containsElement = function (elem) { | |||
| DOMRange.prototype.containsElement = function (elem, selector, event) { | |||
| const templateName = this.view.name?.split('.')[1]; | |||
There was a problem hiding this comment.
I would propose to add some fallback string in case we can't resolve the name:
const templateName = this.view?.name
? this.view.name.split('.')[1]
: 'unknown template'
jankapunkt
approved these changes
Jun 19, 2022
|
@denihs Can you grant @jankapunkt or me the ability to merge PRs instead of having to ask you? |
|
@jankapunkt should be able to do it now. But to release a new version still have to be someone from inside. I can check this later with the team on how we can grant access to this part, in case @jankapunkt also wants to take care of releases. |
|
Fine by me, thank you @denihs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #213