Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore from observe sequence #359

Merged
merged 7 commits into from
Apr 9, 2022

Conversation

harryadel
Copy link
Contributor

@harryadel harryadel commented Jan 22, 2022

As I'm wrapping up meteor/meteor#11869 Test Group 3 is failing because it runs non-core packages and observe-sequence requires underscore which is no longer around since now it's now deprecated. There's no need for publishing a new version of Blaze or Observer-sequence; this PR just needs to be merged in dev branch so in meteor repo the latest commit can pulled. Coincidentally, I'm glad the the underscore removal was done here first as it'd not have worked if it had been done in Meteor repo first. 😅

Copy link
Collaborator

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should still release a patch version of this package or include it in the next release independent of what is happening in the Meteor repo.

@StorytellerCZ
Copy link
Collaborator

Let's merge this into 2.6 release and release 2.6. What do you think @filipenevola ?

Copy link
Member

@fredmaiaarantes fredmaiaarantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harryadel
Copy link
Contributor Author

Any update on this and the 2.6 release? @StorytellerCZ @renanccastro @filipenevola

@StorytellerCZ
Copy link
Collaborator

@fredmaiaarantes @jankapunkt let's include this in 2.6?

Copy link
Collaborator

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would generally add it to 2.6 but I'd like to discuss one more this PR (see my comment on the code).

If this is to be a showstopper (due to further discussion) then we might publish 2.6 with this PR as-is and move the final removal of lodash (see my comment on the code) to 3.0?

packages/observe-sequence/observe_sequence.js Show resolved Hide resolved
@StorytellerCZ StorytellerCZ added this to the Blaze 2.6 milestone Apr 9, 2022
@StorytellerCZ
Copy link
Collaborator

@harryadel can you please address @jankapunkt comment? Then we can merge this into 2.6 and release.

@harryadel
Copy link
Contributor Author

Right away!

@StorytellerCZ StorytellerCZ changed the base branch from master to release-2.6 April 9, 2022 13:03
@StorytellerCZ
Copy link
Collaborator

@harryadel this seems to be the issue of the failing tests:

TypeError: posNew.forEach is not a function
    at diffArray

@harryadel
Copy link
Contributor Author

It's weird that some errors weren't caught by the CI before 🤔

@StorytellerCZ StorytellerCZ merged commit c8f7354 into meteor:release-2.6 Apr 9, 2022
StorytellerCZ added a commit that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants