Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: non array iterables were always treatead as empty #349

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix regression: non array iterables were always treatead as empty #349

merged 1 commit into from
Jul 6, 2021

Conversation

antoinep92
Copy link
Contributor

Issue #347 was fixed by @StorytellerCZ in PR #348, but the fix broke the rich error message (#each value display) for non-array iterables. This PR fixes that regression. The fix works as follow:

  • we add a special case for displaying arrays, that's compatible with IE9+
  • the iterable but not array case is unreachable under IE since, so we use Array.from there

@StorytellerCZ StorytellerCZ merged commit 5992b2e into meteor:fix/for-in-loop Jul 6, 2021
@StorytellerCZ
Copy link
Collaborator

Thanks a lot @antoinep92 !
I will try to release this in the next two hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants