Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for arbitrary iterables in #each templates #341

Merged
merged 3 commits into from
Jun 15, 2021
Merged

add support for arbitrary iterables in #each templates #341

merged 3 commits into from
Jun 15, 2021

Conversation

antoinep92
Copy link
Contributor

Resolves #339
Moved from meteor/meteor#11477 since observe_sequence was moved.

As discussed in the issue, this extends the range of supported {{#each}} arguments to any object implementing the iterable protocol except strings. To minimize changes and risks, these arguments are converted to Arrays, so the iteration mechanics remains unchanged.
IE is not supported.

@antoinep92
Copy link
Contributor Author

Note: I managed to pass all tests locally by running meteor update which bumped versions in test-app/.meteor/ (mongo version was an issue) but didn't commit those changes as this will probably have other consequences and is outside the scope of the PR.

@StorytellerCZ
Copy link
Collaborator

@antoinep92 Thanks for the heads up. I have that fixed in my PR #330

@StorytellerCZ StorytellerCZ changed the base branch from master to release-2.6 June 15, 2021 09:08
@StorytellerCZ StorytellerCZ merged commit 5e3ea02 into meteor:release-2.6 Jun 15, 2021
StorytellerCZ added a commit that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept iterable in each block
2 participants