Spacebars compiler optimisations #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filipenevola Seems to be an error with CircleCI configuration? |
|
Yes @nathan-muir, they were using CircleCI 1.0 which was deprecated. You can see new tests being created here |
|
Hi, tests are fixed on |
As HTML.TransformingVisitor would not visit the elements within each block tag, the OptimisingVisitor would skip a portion of the templates.
Resolves an issue where RawCompactingVisitor would not recurse through any nested elements.
Currently all optimisation within tables is avoided. Even for nested elements.
This prevents optimisation of <table> and <tr> elements, but allows all children of those elements to be optimised.
nathan-muir
force-pushed
the
spacebars-compiler-optimisations
branch
from
dd31a69 to
940c73e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, (@filipenevola reopening #279)
Found a few instances where the spacebars compiler aborts optimisations unnecessarily.
Case 1: Inside Block tags, eg
{{#if }} ... {{else}} ... {{/if}}Case 2: More than one level of nested elements. (Compacting
HTML.Rawfails)Case 3: Inside
<tables>(caused by a pessimistic workaround to auto-injection of<tbody>when usinginnerHTML.)The resolution for Case 1 turned out messier than I had hoped. Due to block tags like
{{#markdown}}that don't contain HTML. Rather than exposing thetextModeprop, maybe something likeisHTML?My motivation for digging through this code, is to implement a
<template whitespace="strip">mode [1]. Which would work similar to react (Strip any whitespace that contains a newline).Early comparisons show that this saves around ~100kb (uncompressed) from my client bundle.
[1] 3stack-software@e779b79