-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTML.isArray to work across frames. #276
Fix HTML.isArray to work across frames. #276
Conversation
Looks like a build issue? |
Hi @brucejo75, do you want to have this PR merged yet? If yes, please comment here so we can re-open, review and merge. |
Sorry, yes I would like this merged... I will take another look if you can reopen. |
@brucejo75 done. |
@filipenevola, I think these are generic build errors? They have nothing to do with my fix... Is someone working on the Blaze regression tests?
|
Yes, here #317 Blaze tests were using CircleCI 1.0 but it was deprecated. |
Hi, tests are fixed on |
@filipenevola, looks like Blaze Tests succeeded but the 1st 2 checks (CLA, ci/circleci) are stuck? |
@brucejo75 they were the old tests. |
Title says it all.
See issue #275.
Also, for reference I ran into a similar issue earlier in meteor that was resolved with pr meteor/meteor#8401. I learned the hard way to retain both forms of Array detection 😄 .