Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-bindata ref and add support for modules #264

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Update go-bindata ref and add support for modules #264

merged 4 commits into from
Jan 24, 2019

Conversation

kainoaseto
Copy link
Contributor

Added support for modules and go-bindata drop in replacement until a better solution can be added in.

zaquestion
zaquestion requested changes Jan 24, 2019
View reviewed changes
Copy link
Member

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for a response to the multiple go1.11 jobs comment and probably dropping go mod download from the Makefile unless its actually needed.

@zaquestion zaquestion merged commit d746697 into metaverse:gomod Jan 24, 2019
@kainoaseto kainoaseto deleted the gomod branch January 24, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaquestion zaquestion zaquestion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainoaseto @zaquestion