Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metagen): add file upload support for Rust client #893

Merged
merged 18 commits into from
Nov 27, 2024

Conversation

Natoandro
Copy link
Contributor

Solve MET-629 (Part 1)

  • Add file upload support to Rust metagen client

Migration notes

N/A

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Natoandro Natoandro requested review from Yohe-Am and j03-dev and removed request for Yohe-Am October 28, 2024 08:01
Yohe-Am
Yohe-Am previously approved these changes Oct 28, 2024
src/metagen/src/shared/files.rs Show resolved Hide resolved
src/metagen/src/client_rs/static/client.rs Outdated Show resolved Hide resolved
src/metagen/src/client_rs/static/client.rs Outdated Show resolved Hide resolved
src/metagen/src/shared/files.rs Show resolved Hide resolved
src/metagen/src/client_rs/static/client.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (9671d60) to head (0bce867).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files         149      149           
  Lines       18500    18500           
  Branches     1794     1795    +1     
=======================================
  Hits        14372    14372           
  Misses       4105     4105           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-0acf4
michael-0acf4 previously approved these changes Oct 30, 2024
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Yohe-Am
Yohe-Am previously approved these changes Oct 30, 2024
.pre-commit-config.yaml Outdated Show resolved Hide resolved
src/metagen/src/shared/files.rs Show resolved Hide resolved
@Natoandro Natoandro dismissed stale reviews from Yohe-Am and michael-0acf4 via 57d7ea6 November 25, 2024 06:15
@Natoandro Natoandro merged commit 2fbb49a into main Nov 27, 2024
13 checks passed
@Natoandro Natoandro deleted the metagen-client-file branch November 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants