-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metagen): add file upload support for Rust client #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natoandro
requested review from
Yohe-Am and
j03-dev
and removed request for
Yohe-Am
October 28, 2024 08:01
Yohe-Am
previously approved these changes
Oct 28, 2024
# Conflicts: # tests/metagen/typegraphs/identities/rs/fdk.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 77.68% 77.68%
=======================================
Files 149 149
Lines 18500 18500
Branches 1794 1795 +1
=======================================
Hits 14372 14372
Misses 4105 4105
Partials 23 23 ☔ View full report in Codecov by Sentry. |
Natoandro
requested review from
Yohe-Am,
zifeo,
michael-0acf4 and
luckasRanarison
October 30, 2024 08:02
michael-0acf4
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Yohe-Am
previously approved these changes
Oct 30, 2024
Natoandro
dismissed stale reviews from Yohe-Am and michael-0acf4
via
November 25, 2024 06:15
57d7ea6
Natoandro
force-pushed
the
metagen-client-file
branch
from
November 26, 2024 08:52
950d3cf
to
72edf81
Compare
luckasRanarison
requested changes
Nov 27, 2024
luckasRanarison
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve MET-629 (Part 1)
Migration notes
N/A