Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): simple diagnostics #496

Merged
merged 62 commits into from
Jan 10, 2024
Merged

feat(lsp): simple diagnostics #496

merged 62 commits into from
Jan 10, 2024

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Nov 28, 2023

Describe your change

Adds a simple LSP implementation for diagnostics.

Motivation and context

Better DX, catch potential errors while editing the typegraph module.

Migration notes

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Natoandro Natoandro requested review from zifeo, michael-0acf4, msga-mmm and Yohe-Am and removed request for msga-mmm November 28, 2023 08:59
@Yohe-Am
Copy link
Contributor

Yohe-Am commented Jan 9, 2024

@Natoandro I think what's happening here is that the dev/lock.ts script is touching some Cargo.toml files from the tree sitter packages pulled in by pnpm. Looking at the rules in dev/lock.yml for Cargo.toml files, those shouldn't really qualify so I'm not sure what's going on.

@Yohe-Am Yohe-Am requested review from zifeo and removed request for zifeo January 10, 2024 00:40
@Natoandro Natoandro requested a review from Yohe-Am January 10, 2024 03:16
@Yohe-Am
Copy link
Contributor

Yohe-Am commented Jan 10, 2024

Ah, so it doesn't let the original author approve a PR even though a separate author pushed the most recent changes.

@Natoandro Natoandro merged commit cf0b8d7 into main Jan 10, 2024
9 checks passed
@Natoandro Natoandro deleted the lsp/diagnostics branch January 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants