fix: make timer cleanup explicit

metatypedev · Jan 29, 2025 · af729a7 · af729a7
1 parent 2bc7721
commit af729a7
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/typegate/src/runtimes/patterns/worker_manager/pooling.ts b/src/typegate/src/runtimes/patterns/worker_manager/pooling.ts
@@ -21,6 +21,7 @@ export type Consumer<T> = (x: T) => void;
 export interface WaitQueue<W> {
   push(consumer: Consumer<W>, onCancel: () => void): void;
   shift(produce: () => W): boolean;
+  clear(): void;
 }
 
 export function createSimpleWaitQueue<W>(): WaitQueue<W> {
@@ -37,6 +38,7 @@ export function createSimpleWaitQueue<W>(): WaitQueue<W> {
       }
       return false;
     },
+    clear() {},
   };
 }
 
@@ -76,6 +78,12 @@ export class WaitQueueWithTimeout<W> implements WaitQueue<W> {
     return false;
   }
 
+  clear() {
+    if (this.#timerId != null) {
+      clearTimeout(this.#timerId);
+    }
+  }
+
   #timeoutHandler() {
     this.#cancelNextEntry();
     this.#updateTimer();
@@ -101,9 +109,7 @@ export class WaitQueueWithTimeout<W> implements WaitQueue<W> {
   }
 
   [Symbol.dispose]() {
-    if (this.#timerId != null) {
-      clearTimeout(this.#timerId);
-    }
+    this.clear();
   }
 }
 
@@ -220,5 +226,6 @@ export class WorkerPool<
     );
     this.#idleWorkers.forEach((worker) => worker.destroy());
     this.#idleWorkers = [];
+    this.#waitQueue.clear();
   }
 }