fix(mint): allow for supply to be set to zero

metaplex-foundation · Nov 19, 2021 · 3802c4e · 3802c4e
1 parent b18efa5
commit 3802c4e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/actions/mintNFT.ts b/src/actions/mintNFT.ts
@@ -18,7 +18,7 @@ interface MintNFTParams {
   connection: Connection;
   wallet: Wallet;
   uri: string;
-  maxSupply?: number;
+  maxSupply: BN | null;
 }
 
 interface MintNFTResponse {
@@ -90,7 +90,7 @@ export const mintNFT = async ({
       updateAuthority: wallet.publicKey,
       mint: mint.publicKey,
       mintAuthority: wallet.publicKey,
-      maxSupply: maxSupply ? new BN(maxSupply) : null,
+      maxSupply,
     },
   );
 

diff --git a/test/actions/mintNFT.test.ts b/test/actions/mintNFT.test.ts
@@ -1,6 +1,6 @@
 import { Keypair } from '@solana/web3.js';
-import axios from 'axios';
-import { Connection, NodeWallet, Wallet } from '../../src';
+import BN from 'bn.js';
+import { Connection, NodeWallet } from '../../src';
 import { mintNFT } from '../../src/actions';
 import { FEE_PAYER } from '../utils';
 import { MasterEdition, Metadata } from '../../src/programs/metadata';
@@ -36,7 +36,7 @@ describe('minting an NFT', () => {
         connection,
         wallet,
         uri,
-        maxSupply: 0,
+        maxSupply: new BN(0),
       });
 
       const metadata = await Metadata.getPDA(mint.publicKey);
@@ -61,7 +61,7 @@ describe('minting an NFT', () => {
           connection,
           wallet,
           uri,
-          maxSupply: 0,
+          maxSupply: new BN(0),
         });
       } catch (e) {
         expect(e).not.toBeNull();