fix(treespec): make PyTreeSpec.is_prefix to be consistent with PyTreeSpec.flatten_up_to
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
bug
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 427 428 +1
=========================================
+ Hits 427 428 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
flatten-up-to
branch
4 times, most recently
from
4c6bb14 to
a918781
Compare
XuehaiPan
force-pushed
the
flatten-up-to
branch
from
5373b9b to
8f9d1d3
Compare
XuehaiPan
force-pushed
the
flatten-up-to
branch
2 times, most recently
from
ea093c6 to
6b3533d
Compare
XuehaiPan
force-pushed
the
flatten-up-to
branch
from
6b3533d to
7310a7a
Compare
JieRen98
reviewed
Oct 11, 2023
| @@ -88,7 +88,7 @@ bool PyTreeSpec::operator==(const PyTreeSpec& other) const { | |||
| // NOLINTNEXTLINE[readability-qualified-auto] | |||
| for (auto a = m_traversal.begin(); a != m_traversal.end(); ++a, ++b) { | |||
| if (a->kind != b->kind || a->arity != b->arity || | |||
| (a->node_data.ptr() == nullptr) != (b->node_data.ptr() == nullptr) || | |||
| static_cast<bool>(a->node_data) != static_cast<bool>(b->node_data) || | |||
There was a problem hiding this comment.
why change this? what's the original type of a->node_data, is it a pointer?
There was a problem hiding this comment.
a->node_data is a py::object. pybind11 suggests to use operator bool() to check whether the py::object instance is set. It is equivalent to this->ptr() != nullptr.
| if (a->kind != b->kind || a->arity != b->arity || | ||
| (a->node_data.ptr() == nullptr) != (b->node_data.ptr() == nullptr) || | ||
| if (a->arity != b->arity || | ||
| static_cast<bool>(a->node_data) != static_cast<bool>(b->node_data) || |
| @@ -288,8 +382,8 @@ py::list PyTreeSpec::Entries() const { | |||
| return py::list{root.node_entries}; | |||
| } | |||
| switch (root.kind) { | |||
| case PyTreeKind::None: | |||
| case PyTreeKind::Leaf: { | |||
| case PyTreeKind::Leaf: | |||
There was a problem hiding this comment.
I reorder the switch cases to match the order of the enum definitions.
|
|
||
| case PyTreeKind::DefaultDict: | ||
| case PyTreeKind::Deque: | ||
| case PyTreeKind::Custom: | ||
| case PyTreeKind::Custom: { |
JieRen98
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)