fix(ops): align kwargs for tree_reduce
with functools.reduce
with the Python C implementation
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
The argument in
tree_reduce
was changed frominitial
toinitializer
in #39. I realized this is a documentation issue in Python. The signature in Python C code isinitial
. This PR reverts the changes for the argument name intree_reduce
.Ref:
functools.reduce
between C implementation, Python implementation, and online documentaion python/cpython#102757functools.reduce
between code and documentation python/cpython#102759Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213I have raised an issue to propose this change (required for new features and bug fixes)
Function signature mismatch for
functools.reduce
between C implementation, Python implementation, and online documentaion python/cpython#102757gh-102757: fix function signature mismatch for
functools.reduce
between code and documentation python/cpython#102759Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)