style: remove useless move found via clang-tidy #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.04% // Head: 94.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 4 4
Lines 319 319
=======================================
Hits 300 300
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Skylion007 could you update the commit with |
9 tasks
Signed-off-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
|
@XuehaiPan done |
|
BTW, instead of make format, consider pre-commit as it could apply changes like clang-format automatically to PRs |
XuehaiPan
approved these changes
Jan 23, 2023
XuehaiPan
changed the title
|
@Skylion007 Thanks for your contribution and suggestions. |
9 tasks
XuehaiPan
added a commit
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Gokaslan aaronGokaslan@gmail.com
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!