Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataclasses): add dataclasses integration #142

Merged
merged 25 commits into from
Sep 11, 2024

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Resolves #122

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added enhancement New feature or request py Something related to the Python source code integration Integration for other packages labels Jun 8, 2024
@XuehaiPan XuehaiPan self-assigned this Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (35618b3) to head (34b5b58).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #142    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           10        11     +1     
  Lines         1021      1150   +129     
==========================================
+ Hits          1021      1150   +129     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the dataclasses branch 2 times, most recently from 86e22c7 to 3fcf95f Compare June 9, 2024 19:34
@XuehaiPan XuehaiPan force-pushed the dataclasses branch 3 times, most recently from d5355b3 to 3bcf53b Compare June 30, 2024 10:47
@XuehaiPan XuehaiPan force-pushed the dataclasses branch 3 times, most recently from f2f13d1 to f7671f2 Compare July 19, 2024 15:00
@XuehaiPan XuehaiPan force-pushed the dataclasses branch 2 times, most recently from a6ac477 to 1b5f1ee Compare August 1, 2024 15:04
@srush
Copy link

srush commented Aug 30, 2024

Any updates on this? Can I help?

This feature is keeping me from porting a bunch of code to optree.

@XuehaiPan
Copy link
Member Author

Any updates on this?

Thanks for pinging this. The PR is almost done. I will add some unit tests and get it merged this weekend.

@XuehaiPan XuehaiPan force-pushed the dataclasses branch 2 times, most recently from 882da68 to d3f2d07 Compare September 2, 2024 06:45
@XuehaiPan XuehaiPan marked this pull request as ready for review September 10, 2024 18:24
@XuehaiPan XuehaiPan requested a review from JieRen98 September 10, 2024 18:24
@XuehaiPan XuehaiPan force-pushed the dataclasses branch 5 times, most recently from 7a39408 to 3ec7266 Compare September 11, 2024 12:14
@XuehaiPan XuehaiPan merged commit 0d2f38d into metaopt:main Sep 11, 2024
111 checks passed
@XuehaiPan XuehaiPan deleted the dataclasses branch September 11, 2024 18:01
@srush
Copy link

srush commented Sep 11, 2024

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration Integration for other packages py Something related to the Python source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add equivalent for flax.struct.dataclass
2 participants