-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose renaming sseqtr4i and sseqtr4d #3652
Conversation
The pattern is to use the 3/4 naming convention if both hypotheses are symmetric, but "r" if only one hypothesis is symmetric.
Well, some of the proposed renames above use "com", like syl6rbb --> bitrdicom. This is mostly unrelated to replacing "syl5/syl6" but I wonder what the difference between "com" and "r" is. The conventions mention "r" ~~ right and "com" ~~ commutativity. |
One explanation is that "r" applies to hypotheses and "com" to conclusions, but after further thought this is also represented with the (1)/2/3/4 system:
And on further thought some of these r vs com issues would probably be in another pr. (The corrections to sylbb don't affect this pr, jkingdon's original reasoning above still holds) |
That has been my thinking, yes.
Hmm, interesting. I especially found examples like
Agreed, looks good as proposed in changes-set.txt.
Yes,
So then would you change the order of the two hypotheses? I notice that there were a bunch of changes from Feb-2013 described with "reordered hypotheses for better logical flow" which I guess I take mostly as precedent that we can consider hypothesis order as well as names if we'd like.
Agreed, looks good as proposed in changes-set.txt.
Agreed, looks good as proposed in changes-set.txt.
bitr4id would work if the order of the hypotheses is changed.
Yes,
Agreed, looks good as proposed in changes-set.txt.
Yeah, it seems like we could merge this one (which just has two proposed renames) and make another pull request for the follow up. Did you want to make the follow up pull request or should I? |
I went ahead and made the follow up pr |
The pattern is to use the 3/4 naming convention if both hypotheses are symmetric, but "r" if only one hypothesis is symmetric.