Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support syntax 'A' 'B' 'C'; command, style #144

Merged
merged 1 commit into from
Oct 18, 2023
Merged

support syntax 'A' 'B' 'C'; command, style #144

merged 1 commit into from
Oct 18, 2023

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Sep 30, 2023

These are the code cleanup changes from #137. The only actual functionality change here is that syntax 'A' 'B'; parses as intended. The rest is just using let else more and some typos in panic messages.

tirix
tirix approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@tirix tirix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also makes use of ther new let .. else construct form to simplify at several places.
Ok for me, good to keep those changes from your original PR.

@tirix tirix merged commit cf25861 into main Oct 18, 2023
8 checks passed
@tirix tirix mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirix tirix tirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digama0 @tirix