Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores in comment's Html #129

Closed
wants to merge 4 commits into from
Closed

Conversation

tirix
Copy link
Collaborator

@tirix tirix commented Sep 26, 2023

Originally opened because of #128 to avoid issuing a diagnostic in case a non-doubled underscore is found in an URL.

Changed into fixing the handling of underscores in HTML.

Fixes #131

@digama0
Copy link
Member

digama0 commented Sep 26, 2023

not issuing the diagnostic is incorrect, if we are in fact undoubling underscores. The point of the diagnostic is that if __ will be turned into _ then _ alone is probably an error, even though it will be preserved.

@tirix tirix changed the title Underscores in comment Urls Underscores in comment Urls and Html Sep 26, 2023
@tirix
Copy link
Collaborator Author

tirix commented Sep 26, 2023

not issuing the diagnostic is incorrect, if we are in fact undoubling underscores.

Indeed in CommentItem comment section, unescape_text is supposed to be run for Urls. In that case, the issue #128 is not an issue and does not need to be fixed. In set.mm however, no underscore is doubled in Urls. This boils down to what we want the standard to be.

@tirix tirix changed the title Underscores in comment Urls and Html Underscores in comment's Html Sep 26, 2023
@tirix
Copy link
Collaborator Author

tirix commented Sep 26, 2023

I'm making use of this PR to fix the behaviour of underscores in HTML (sorry for the change, I hope it's not a too bad practice)

The comments clearly states:

In HTML mode subscripts and italics are disabled, and HTML markup is interpreted

So there is no point to escaping underscores in HTML mode.

@tirix
Copy link
Collaborator Author

tirix commented Sep 26, 2023

Superseded by #130 .

@tirix tirix closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubling underscores in HTML mode
2 participants