Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README file #19

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update README file #19

merged 1 commit into from
Sep 27, 2024

Conversation

mboukhalfa
Copy link
Member

Add FakeIPA to the root README file

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2024
@mboukhalfa
Update readme
730896d 
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
@mboukhalfa mboukhalfa force-pushed the Update-readme/mboukhalfa branch from 6b10ed4 to 730896d Compare September 18, 2024 15:55
Rozzii
Rozzii reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I am fine with this commit but if possible create further PRs that extend the READMI with documentation related to the usage of the fake-ipa tool eg. an example workflow or something similar.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@tuminoid
Copy link
Member

/approve

I am fine with this commit but if possible create further PRs that extend the READMI with documentation related to the usage of the fake-ipa tool eg. an example workflow or something similar.

Can we please make such additions under fake-ipa README. I don't think the global readme needs more than this quick intro, and a link to further reading.

tuminoid
tuminoid reviewed Sep 20, 2024
View reviewed changes
README.md
- Heartbeating to Ironic API with several threads looping over
a queue of fake agents.
- Faking the sync/async commands needed by ironic to inspect,
clean and provision a node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a "read more" link to fake-ipa/README.md for more docs.

tuminoid
tuminoid reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@metal3-io-bot metal3-io-bot merged commit 6662db5 into metal3-io:main Sep 27, 2024
3 checks passed
@metal3-io-bot metal3-io-bot deleted the Update-readme/mboukhalfa branch September 27, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mboukhalfa @metal3-io-bot @tuminoid @Rozzii