Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables optionally multiplatform container builds #960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enables optionally multiplatform container builds #960

wants to merge 1 commit into from

Conversation

e-minguez
Copy link

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunnatillo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2025
@metal3-io-bot
Copy link
Collaborator

Hi @e-minguez. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2025
@e-minguez e-minguez force-pushed the multi-arch-builds-sushy-tools branch from 3c038b4 to 219d75e Compare February 3, 2025 13:43
@e-minguez e-minguez mentioned this pull request Feb 3, 2025
Open
kashifest
kashifest reviewed Feb 3, 2025
View reviewed changes
.github/workflows/container-image-build.yml
required: false
description: "Architecture platforms for the image build (linux/amd64,linux/arm64, etc.)"
type: string
default: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking if we would need a default value here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess (honestly, I didn't tested it) that if you don't explicitly set multiPlatform: true this will be ignored and built against the arch where it has been executed (linux/amd64 by default IIRC)

@kashifest
Copy link
Member

@e-minguez thanks a lot for the PR, please check the DCO failure and fix it

@kashifest
Copy link
Member

/cc @tuminoid @Rozzii @lentzi90

@kashifest
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@e-minguez e-minguez force-pushed the multi-arch-builds-sushy-tools branch from 219d75e to 46101a9 Compare February 3, 2025 16:40
@e-minguez
Enables optionally multiplatform container builds
e0cdab7 
Signed-off-by: e-minguez <e.minguez@gmail.com>
@e-minguez e-minguez force-pushed the multi-arch-builds-sushy-tools branch from 46101a9 to e0cdab7 Compare February 3, 2025 16:40
@lentzi90
Copy link
Member

lentzi90 commented Feb 3, 2025

/test check-prow-config

@metal3-io-bot
Copy link
Collaborator

@e-minguez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-prow-config e0cdab7 link true /test check-prow-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lentzi90
Copy link
Member

lentzi90 commented Feb 3, 2025

The prow-config test failure is irrelevant. We have some issue with the infra. Please ignore for now

Rozzii
Rozzii reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Why not...
I am not sure this will actually produce a working container but let's see.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
tuminoid
tuminoid reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I need some time to look at this. I'm not fond of possibly breaking all builds.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@kashifest kashifest kashifest left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@e-minguez @metal3-io-bot @kashifest @lentzi90 @tuminoid @Rozzii