-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow: Use flavors with local disk #924
Conversation
To improve performance and reduce the risk of network issues due to volumes mounted over network, we switch to flavors with local disk. Root volumes are no longer needed. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
/override metal3-ubuntu-e2e-integration-test-main The changes are already applied. As you can see, the flavors are a bit bigger than what we used to have. If it turns out that we are wasting resources this way, we may ask for smaller flavors in the future. For now I think we can try this. |
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agree, let's start with this and get the prow monitoring done, then we have data to make decisions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
To improve performance and reduce the risk of network issues due to volumes mounted over network, we switch to flavors with local disk. Root volumes are no longer needed.
Fixes: #922