Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Use flavors with local disk #924

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 4, 2024

To improve performance and reduce the risk of network issues due to volumes mounted over network, we switch to flavors with local disk. Root volumes are no longer needed.

Fixes: #922

To improve performance and reduce the risk of network issues due to
volumes mounted over network, we switch to flavors with local disk. Root
volumes are no longer needed.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Dec 4, 2024

/override metal3-ubuntu-e2e-integration-test-main

The changes are already applied. As you can see, the flavors are a bit bigger than what we used to have. If it turns out that we are wasting resources this way, we may ask for smaller flavors in the future. For now I think we can try this.

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

The changes are already applied. As you can see, the flavors are a bit bigger than what we used to have. If it turns out that we are wasting resources this way, we may ask for smaller flavors in the future. For now I think we can try this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Dec 4, 2024

/override metal3-ubuntu-e2e-integration-test-main

The changes are already applied. As you can see, the flavors are a bit bigger than what we used to have. If it turns out that we are wasting resources this way, we may ask for smaller flavors in the future. For now I think we can try this.

Agree, let's start with this and get the prow monitoring done, then we have data to make decisions.

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@metal3-io-bot metal3-io-bot merged commit 691b232 into metal3-io:main Dec 4, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/prow-est-flavors branch December 4, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prow: stop using volumes and use local disk instead
4 participants