Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update for CAPM3 and IPAM release-1.7 and BMO 0.6.0 #697

Merged
merged 1 commit into from
Apr 22, 2024
Merged

🌱 Update for CAPM3 and IPAM release-1.7 and BMO 0.6.0 #697

merged 1 commit into from
Apr 22, 2024

Conversation

adilGhaffarDev
Copy link
Member

Updating prow config to accommodate CAPM3 and IPAM release-1.7 and BMO release-0.6.0

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 12, 2024
@adilGhaffarDev
Copy link
Member Author

/hold
until we have new releases for CAPM3, IPAM and BMO.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Apr 12, 2024
Closed
12 tasks
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 17, 2024
kashifest
kashifest reviewed Apr 19, 2024
View reviewed changes
jenkins/README.md Outdated
* **/keep-test-ubuntu-integration-release-1-7** run keep integration tests with
CAPM3 API version v1beta1 and branch release-1.7 on Ubuntu
* **/keep-test-centos-integration-release-1-7** run keep integration tests with
CAPM3 API version v1beta1 and branch release-1.7 on CentOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arent we removing keep tests ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased now they are gone.

@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
smoshiur1237
smoshiur1237 reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
kashifest
kashifest reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
cc @mboukhalfa @tuminoid

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@adilGhaffarDev
Update for CAPM3 and IPAM release-1.7 and BMO 0.6.0
efabae0 
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
Sunnatillo
Sunnatillo reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@adilGhaffarDev
Copy link
Member Author

/metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

last failure was flake

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot merged commit d1c6bfb into metal3-io:main Apr 22, 2024
6 checks passed
@metal3-io-bot
Copy link
Collaborator

@adilGhaffarDev: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Updating prow config to accommodate CAPM3 and IPAM release-1.7 and BMO release-0.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adilGhaffarDev adilGhaffarDev mentioned this pull request Aug 13, 2024
Closed
50 tasks
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adilGhaffarDev @metal3-io-bot @Sunnatillo @kashifest @smoshiur1237