Remove redundant prow jobs covered by golangci-lint

[lentzi90]

BMO:

• Remove gofmt for main and release-0.5. They have GitHub actions that
  run golangci-lint and includes gofmt.
• Older release branches do not have the GitHub action so they are left
  as is.
• Remove golint for main and release-0.5 as we have GitHub actions for
  them.
• Add test jobs for verifying that the scripts and make targets work.

CAPM3:

• Remove gofmt, govet and gosec. They are all part of golangci-lint for all
  tested branches. Release-1.4 has a prow job, the rest have GitHub
  actions.

IPAM:

• Remove gosec, gofmt and govet. They are all part of golangci-lint for
  all tested branches. Release-1.4 has a prow job, the rest have GitHub
  actions.

Please check carefully!
/hold

[tuminoid]

/cc @kashifest
to check this, golangci is mostly his work.

[tuminoid]

@tuminoid for some reason I dont see the workflow file in 0.5 branch either, are you sure the golangci-lint action is active on that branch ? IMO we should only remove from main branch.

OK, the workflow file isn't there as I expected. Then only main can be removed, or we can add the workflow file in 0.5?

[kashifest]

@tuminoid for some reason I dont see the workflow file in 0.5 branch either, are you sure the golangci-lint action is active on that branch ? IMO we should only remove from main branch.

OK, the workflow file isn't there as I expected. Then only main can be removed, or we can add the workflow file in 0.5?

Yes, I will add it

[lentzi90]

@tuminoid for some reason I dont see the workflow file in 0.5 branch either, are you sure the golangci-lint action is active on that branch ? IMO we should only remove from main branch.

OK, the workflow file isn't there as I expected. Then only main can be removed, or we can add the workflow file in 0.5?

Yes, I will add it

Thanks! Then I will remove gofmt from main and release-0.5 here and we can merge after the action is added in 0.5. I noticed also that we have a redundant golint for BMO main. I will remove that as well.

[tuminoid]

Thanks! Then I will remove gofmt from main and release-0.5 here and we can merge after the action is added in 0.5. I noticed also that we have a redundant golint for BMO main. I will remove that as well.

Follow-up with removal of the hack scripts and Makefile targets in each repo as well as they are removed from here to remove the cruft to maintain for no value.

[lentzi90]

Follow-up with removal of the hack scripts and Makefile targets in each repo as well as they are removed from here to remove the cruft to maintain for no value.

I have added these as tasks for the contrib-fest 😄

[lentzi90]

/override test-ubuntu-integration-main

[metal3-io-bot]

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kashifest]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/hold cancel
/cc @tuminoid

[tuminoid]

/lgtm

[metal3-io-bot]

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

• key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

BMO:

• Remove gofmt for main and release-0.5. They have GitHub actions that
  run golangci-lint and includes gofmt.
• Older release branches do not have the GitHub action so they are left
  as is.
• Remove golint for main and release-0.5 as we have GitHub actions for
  them.
• Add test jobs for verifying that the scripts and make targets work.

CAPM3:

• Remove gofmt, govet and gosec. They are all part of golangci-lint for all
  tested branches. Release-1.4 has a prow job, the rest have GitHub
  actions.

IPAM:

• Remove gosec, gofmt and govet. They are all part of golangci-lint for
  all tested branches. Release-1.4 has a prow job, the rest have GitHub
  actions.

Please check carefully!
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.