Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-prow images as needed #651

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Update k8s-prow images as needed #651

merged 1 commit into from
Mar 4, 2024

Conversation

metal3-io-bot
Copy link
Collaborator

Multiple distinct gcr.io/k8s-prow/ changes:

Commits Dates Images
d4f3b08...d64ece9 2024‑02‑23 → 2024‑02‑28 checkconfig, cherrypicker, clonerefs, commenter, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, label_sync, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Nobody is currently oncall, so falling back to Blunderbuss.

Bumping k8s-prow images
406f6b0 
Multiple distinct gcr.io/k8s-prow/ changes:

Commits | Dates | Images
--- | --- | ---
metal3-io/project-infra@d4f3b08...d64ece9 | 2024‑02‑23 → 2024‑02‑28 | checkconfig, cherrypicker, clonerefs, commenter, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, label_sync, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Signed-off-by: ci-robot <ci-robot@k8s.io>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

Can we adjust how often these images are bumped? I don't think we want them bumped every week even.
@lentzi90

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

Yeah we can adjust it here: https://github.com/metal3-io/project-infra/blob/47f8ebcd707cb28a37881f3e691b364925421702/prow/manifests/overlays/metal3/config.yaml#L312C1-L312C20
What would be good? Every other week? Monthly?

@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

What would be good? Every other week? Monthly?

I would say monthly. We used to do it yearly before :) @kashifest any opionions?

@kashifest
Copy link
Member

I would say monthly. We used to do it yearly before :) @kashifest any opionions?

May be Monthly/ Quarterly (every 3 months)?

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

Monthly sounds good. I can do a PR to update it 🙂

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
tuminoid
tuminoid reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
lentzi90
lentzi90 reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

/override test-ubuntu-integration-main

I'll apply the changes when it merges

@metal3-io-bot
Copy link
Collaborator Author

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

I'll apply the changes when it merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 9fba5bf into metal3-io:main Mar 4, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator Author

@metal3-io-bot: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Multiple distinct gcr.io/k8s-prow/ changes:

Commits Dates Images
d4f3b08...d64ece9 2024‑02‑23 → 2024‑02‑28 checkconfig, cherrypicker, clonerefs, commenter, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, label_sync, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Nobody is currently oncall, so falling back to Blunderbuss.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @tuminoid @lentzi90 @kashifest