Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pipeline to test triggering basic e2e from prow #642

Merged

Conversation

mboukhalfa
Copy link
Member

No description provided.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2024
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
@mboukhalfa mboukhalfa force-pushed the Basic-e2e-test-prow-trigger/mboukhalfa branch from 566e17d to 1a843ba Compare February 28, 2024 18:17
@adilGhaffarDev
Copy link
Member

we are adding a new pipeline script anyhow, can we use dynamic workers here while we are at it?

@mboukhalfa
Copy link
Member Author

mboukhalfa commented Feb 29, 2024

we are adding a new pipeline script anyhow, can we use dynamic workers here while we are at it?

This is just testing the changes with basic e2e once we get this working we can re draw a design in term of the dynamic workers and the pipeline separation

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

jenkins/jobs/prow_integration_tests.pipeline Show resolved Hide resolved
@mboukhalfa
Copy link
Member Author

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@mboukhalfa: Overrode contexts on behalf of mboukhalfa: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@metal3-io-bot metal3-io-bot merged commit 267937d into metal3-io:main Feb 29, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@mboukhalfa: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants