✨ Added generic-autobumper to update all prow images #632
Conversation
metal3-io-bot
added
the
size/L
peppi-lotta
changed the title
peppi-lotta
changed the title
prow/manifests/overlays/metal3/external-plugins/generic-autobumper-config.yaml
Outdated
Show resolved
Hide resolved
prow/manifests/overlays/metal3/external-plugins/generic-autobumper-config.yaml
Outdated
Show resolved
Hide resolved
prow/manifests/overlays/metal3/external-plugins/generic-autobumper-deployment.yaml
Outdated
Show resolved
Hide resolved
peppi-lotta
force-pushed
the
feature/general-autobumper-for-prow_PEPPI
branch
from
fee04e6 to
6287131
Compare
metal3-io-bot
added
do-not-merge/hold
| @@ -37,6 +38,10 @@ configMapGenerator: | |||
| - labels.yaml | |||
| name: label-config | |||
| namespace: prow | |||
| - files: | |||
| - config.yaml=external-plugins/generic-autobumper-deployment.yaml | |||
There was a problem hiding this comment.
| - config.yaml=external-plugins/generic-autobumper-deployment.yaml | |
| - config.yaml=external-plugins/generic-autobumper-config.yaml |
| ports: | ||
| - containerPort: 8888 |
There was a problem hiding this comment.
We can remove this as it should not be listening on any ports
| ports: | |
| - containerPort: 8888 |
peppi-lotta
force-pushed
the
feature/general-autobumper-for-prow_PEPPI
branch
from
6bc9613 to
3e4c4e5
Compare
metal3-io-bot
added
the
do-not-merge/work-in-progress
peppi-lotta
force-pushed
the
feature/general-autobumper-for-prow_PEPPI
branch
from
ac6eac3 to
61733b5
Compare
metal3-io-bot
removed
the
do-not-merge/work-in-progress
| - name: config | ||
| configMap: | ||
| name: generic-autobumper-config |
There was a problem hiding this comment.
We can skip this since we anyway have the whole repository cloned, so we can just set the path to the config file within the repository
| - --labels-override=skip-review | ||
| - --skip-if-no-oncall |
There was a problem hiding this comment.
I think we should remove these. We do not have any on-call configured and I think the normal review flow should work fine
| - --labels-override=skip-review | |
| - --skip-if-no-oncall |
| @@ -301,6 +301,37 @@ periodics: | |||
| - name: token | |||
| secret: | |||
| secretName: github-token | |||
| - name: autobump-prow-images | |||
| interval: 24h | |||
| cluster: prow | |||
There was a problem hiding this comment.
We only have one cluster (I think it is called default) but no need to specify anything here
| cluster: prow |
peppi-lotta
force-pushed
the
feature/general-autobumper-for-prow_PEPPI
branch
from
dd91d28 to
8d7c2da
Compare
Signed-off-by: peppi-lotta <peppi-lotta.saari@est.tech>
peppi-lotta
force-pushed
the
feature/general-autobumper-for-prow_PEPPI
branch
from
8d7c2da to
27f4077
Compare
|
/test-ubuntu-integration-main |
metal3-io-bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, Rozzii, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@peppi-lotta: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added automatic bumper to update all prow images to make developers lives easier. I've implemented the prow Prow generic-autobumper to achieve this. A prow job was defined to periodically(once a day) look for new images. When new images are found the auto bumper makes new a new pull request which can then just be approved.
Once this is proven to work the current implementation for image updating can be removed. (This means the image list in prow/manifests/overlays/metal3/kustomizatin.yaml)