-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update required contexts for BMO #630
Update required contexts for BMO #630
Conversation
The BMO e2e tests have now been required for PRs in BMO for a couple of weeks already. They test more extensively and efficiently than the old integration test so I suggest we make it optional. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
dbe3923
to
b8d3164
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Ping me to remove the required context on GH side when this is merged
/cc @Rozzii @smoshiur1237 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smoshiur1237, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override test-ubuntu-integration-main |
@smoshiur1237: smoshiur1237 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override test-ubuntu-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lentzi90: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Removed on GH side too. |
The BMO e2e tests have now been required for PRs in BMO for a couple of weeks already. They test more extensively and efficiently than the old integration test so I suggest we make it optional.