Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required contexts for BMO #630

Merged

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Feb 1, 2024

The BMO e2e tests have now been required for PRs in BMO for a couple of weeks already. They test more extensively and efficiently than the old integration test so I suggest we make it optional.

The BMO e2e tests have now been required for PRs in BMO for a couple of
weeks already. They test more extensively and efficiently than the old
integration test so I suggest we make it optional.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/bmo-required-contexts branch from dbe3923 to b8d3164 Compare February 1, 2024 06:52
@maxrantil
Copy link

LGTM

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Ping me to remove the required context on GH side when this is merged

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 1, 2024

/cc @Rozzii @smoshiur1237

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smoshiur1237
Copy link
Member

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@smoshiur1237: smoshiur1237 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit a91ffdf into metal3-io:main Feb 1, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

The BMO e2e tests have now been required for PRs in BMO for a couple of weeks already. They test more extensively and efficiently than the old integration test so I suggest we make it optional.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the lentzi90/bmo-required-contexts branch February 1, 2024 13:21
@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

Ping me to remove the required context on GH side when this is merged

Removed on GH side too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants