Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullstack test #629

Closed
wants to merge 1 commit into from
Closed

Add fullstack test #629

wants to merge 1 commit into from

Conversation

mboukhalfa
Copy link
Member

Move fullstack test from dev-tools

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboukhalfa. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fullstack-building-pipeline/mohammed branch 2 times, most recently from 5bda958 to b18086e Compare January 31, 2024 16:00
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fullstack-building-pipeline/mohammed branch from b18086e to 7c86d41 Compare January 31, 2024 16:39
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2024
@mboukhalfa
Add fullstack test
8531b3f 
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
@mboukhalfa mboukhalfa force-pushed the Add-fullstack-building-pipeline/mohammed branch from 7c86d41 to 8531b3f Compare January 31, 2024 16:46
@tuminoid
Copy link
Member

tuminoid commented Feb 1, 2024

/hold
Needs JJB changes too right?

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@mboukhalfa
Copy link
Member Author

/hold Needs JJB changes too right?

Yes we need to merge the jjb first to be able to trigger tests here

@mboukhalfa mboukhalfa mentioned this pull request Feb 1, 2024
Merged
@mboukhalfa
Copy link
Member Author

/test-metal3-fullstack

1 similar comment
@mboukhalfa
Copy link
Member Author

/test-metal3-fullstack

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024
@metal3-io-bot
Copy link
Collaborator

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Collaborator

@metal3-io-bot: Closed this PR.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboukhalfa @metal3-io-bot @tuminoid