Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to v1.21 for BMO prow jobs #627

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Bump golang to v1.21 for BMO prow jobs #627

merged 1 commit into from
Feb 9, 2024

Conversation

kashifest
Copy link
Member

as the title says

@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2024
@kashifest kashifest force-pushed the bump/golang-v1.21-bmo-main branch from 61fc923 to 1f52b2b Compare January 30, 2024 14:43
@kashifest
Bump golang to v1.21 for BMO prow jobs
780a32d 
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest kashifest force-pushed the bump/golang-v1.21-bmo-main branch from 1f52b2b to 780a32d Compare January 30, 2024 14:46
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@kashifest kashifest mentioned this pull request Jan 30, 2024
Merged
tuminoid
tuminoid reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@tuminoid
Copy link
Member

tuminoid commented Feb 9, 2024

/hold
To coordinate with the BMO PR.
/cc @lentzi90
for LGTM

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
lentzi90
lentzi90 reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@metal3-io-bot metal3-io-bot merged commit 90ed6a9 into metal3-io:main Feb 9, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@kashifest: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

as the title says

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest kashifest deleted the bump/golang-v1.21-bmo-main branch February 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifest @metal3-io-bot @tuminoid @lentzi90