Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-1.6 branch configurations for CAPM3/IPAM repos #613

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

smoshiur1237
Copy link
Member

Adding release-1.6 branch configurations for CAPM3/IPAM repos

Signed-off-by: smoshiur1237 <moshiur.rahman@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2024
@smoshiur1237
Copy link
Member Author

/test-ubuntu-integration-main

@smoshiur1237
Copy link
Member Author

smoshiur1237 commented Jan 9, 2024

/cc @tuminoid @Sunnatillo

@metal3-io-bot
Copy link
Collaborator

@smoshiur1237: GitHub didn't allow me to request PR reviews from the following users: kashif.

Note that only metal3-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kashif @tuminoid @Sunnatillo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@kashif
Copy link

kashif commented Jan 9, 2024

why am i being tagged here?

@Sunnatillo
Copy link
Member

/cc @kashifest

@kashif
Copy link

kashif commented Jan 9, 2024

@smoshiur1237 please have the courtesy to remove me from this as i keep getting notifications... i completely understand typos being made (this is the 2nd time BTW) but then kindly fix it

@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2024

@smoshiur1237 please have the courtesy to remove me from this as i keep getting notifications... i completely understand typos being made (this is the 2nd time BTW) but then kindly fix it

Hey Kashif, apologies for the typos made. Like the bot commented, it couldn't add you as reviewer, so the original message is the only notification you should be getting. We cannot subscribe or unsubscribe you to/from notifications on this PR, beyond explicitly tagging you in the comment, so you shouldn't be getting any further notifications, unless you subscribed yourself.

Sorry for the inconvenience again.

@kashifest
Copy link
Member

So we drop the oldest branch tests in a follow up or shall we do it in the same PR ?

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2024

So we drop the oldest branch tests in a follow up or shall we do it in the same PR ?

IMO Let's do it in another one. We might get rid of some sections completely, makes nicer diff.

@metal3-io-bot metal3-io-bot merged commit 0618275 into metal3-io:main Jan 9, 2024
6 checks passed
@metal3-io-bot
Copy link
Collaborator

@smoshiur1237: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Adding release-1.6 branch configurations for CAPM3/IPAM repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo deleted the add-new-release-moshiur branch January 9, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants