-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-1.6 branch configurations for CAPM3/IPAM repos #613
Conversation
Signed-off-by: smoshiur1237 <moshiur.rahman@est.tech>
/test-ubuntu-integration-main |
/cc @tuminoid @Sunnatillo |
@smoshiur1237: GitHub didn't allow me to request PR reviews from the following users: kashif. Note that only metal3-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
why am i being tagged here? |
/cc @kashifest |
@smoshiur1237 please have the courtesy to remove me from this as i keep getting notifications... i completely understand typos being made (this is the 2nd time BTW) but then kindly fix it |
Hey Kashif, apologies for the typos made. Like the bot commented, it couldn't add you as reviewer, so the original message is the only notification you should be getting. We cannot subscribe or unsubscribe you to/from notifications on this PR, beyond explicitly tagging you in the comment, so you shouldn't be getting any further notifications, unless you subscribed yourself. Sorry for the inconvenience again. |
So we drop the oldest branch tests in a follow up or shall we do it in the same PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
IMO Let's do it in another one. We might get rid of some sections completely, makes nicer diff. |
@smoshiur1237: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding release-1.6 branch configurations for CAPM3/IPAM repos