Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metal3-io/community repository in prow config #599

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add metal3-io/community repository in prow config #599

merged 1 commit into from
Dec 1, 2023

Conversation

kashifest
Copy link
Member

This PR also adds a markdownlint prow job for the repo.

@kashifest
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
smoshiur1237
smoshiur1237 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@tuminoid
Copy link
Member

tuminoid commented Dec 1, 2023

We should first add OWNERS etc befiore activating Prow?

@smoshiur1237
Copy link
Member

/override test-ubuntu-integration-main
These changes are not tested by integration test.

@metal3-io-bot
Copy link
Collaborator

@smoshiur1237: smoshiur1237 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-ubuntu-integration-main
These changes are not tested by integration test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member Author

We should first add OWNERS etc befiore activating Prow?

I have that PR up as well, now thinking which one should land first

@tuminoid
Copy link
Member

tuminoid commented Dec 1, 2023

We should first add OWNERS etc befiore activating Prow?

I have that PR up as well, now thinking which one should land first

If you don't have OWNERS in place, landing this first making merging anything else more difficult. You basically need to override Prow and manually merge stuff etc. So its just less steps to merge the OWNERS PR first IMO.

@kashifest
Copy link
Member Author

ok I will fetch out OWNERS file and merge it first

tuminoid
tuminoid reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

One nit, plus OWNERS PR should land first.

prow/manifests/overlays/metal3/config.yaml Show resolved Hide resolved
prow/manifests/overlays/metal3/config.yaml Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2023
Rozzii
Rozzii previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/test-ubuntu-integration-main

@Rozzii
Copy link
Member

Rozzii commented Dec 1, 2023

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@Rozzii
Copy link
Member

Rozzii commented Dec 1, 2023

/test-ubuntu-integration-main

@smoshiur1237
Copy link
Member

/hold
We can skip the test after removing the empty line.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@smoshiur1237
Copy link
Member

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@smoshiur1237: smoshiur1237 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Add metal3-io/community in prow config. This PR also adds a markdownl…
8614f90 
…int prow job for the repo

Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
smoshiur1237
smoshiur1237 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 1, 2023
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii, smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member

tuminoid commented Dec 1, 2023

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit aa1a638 into metal3-io:main Dec 1, 2023
1 check passed
@metal3-io-bot
Copy link
Collaborator

@kashifest: Updated the following 2 configmaps:

  • plugins configmap in namespace prow at cluster default using the following files:
    • key plugins.yaml using file prow/manifests/overlays/metal3/plugins.yaml
  • config configmap in namespace prow at cluster default using the following files:
    • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

This PR also adds a markdownlint prow job for the repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the add/community-repo branch December 1, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@Rozzii Rozzii Rozzii left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashifest @tuminoid @smoshiur1237 @metal3-io-bot @Rozzii