Catch curl uploading error when upload fails

Also corrects conditions of number comparions. Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
metal3-io · Nov 5, 2024 · df41296 · df41296
1 parent 8103e5a
commit df41296
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/jenkins/image_building/upload-node-image.sh b/jenkins/image_building/upload-node-image.sh
@@ -10,7 +10,7 @@ rt_delete_artifact() {
 rt_upload_artifact() {
     local src_path="${1:?}"
     local dst_path="${2:?}"
-    curl -s -XPUT -u"${RT_USER:?}:${RT_TOKEN:?}" "${RT_URL}/${dst_path}" -T "${src_path}"
+    curl -s --fail-with-body -XPUT -u"${RT_USER:?}:${RT_TOKEN:?}" "${RT_URL}/${dst_path}" -T "${src_path}"
 }
 
 rt_list_directory() {

diff --git a/jenkins/scripts/artifactory/utils.sh b/jenkins/scripts/artifactory/utils.sh
@@ -21,7 +21,8 @@ rt_upload_artifact() {
   ANONYMOUS="${3:-1}"
 
   _CMD="curl \
-    $( ([[ "${ANONYMOUS}" != 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
+    --fail-with-body \
+    $( ([[ ""${ANONYMOUS}" -ne 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
     ${RT_URL}/${DST_PATH} \
     -T ${SRC_PATH}"
 
@@ -46,7 +47,7 @@ rt_download_artifact() {
   ANONYMOUS="${3:-1}"
 
   _CMD="curl -s \
-    $( ([[ "${ANONYMOUS}" != 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
+    $( ([[ ""${ANONYMOUS}" -ne 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
     -XGET \
     ${RT_URL}/${SRC_PATH} \
     -o ${DST_PATH}"
@@ -71,7 +72,7 @@ rt_cat_artifact() {
   ANONYMOUS="${2:-1}"
 
   _CMD="curl -s \
-    $( ([[ "${ANONYMOUS}" != 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
+    $( ([[ ""${ANONYMOUS}" -ne 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
     -XGET \
     ${RT_URL}/${SRC_PATH}"
 
@@ -95,7 +96,7 @@ rt_delete_artifact() {
   ANONYMOUS="${2:-1}"
 
   _CMD="curl -s \
-    $( ([[ "${ANONYMOUS}" != 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
+    $( ([[ ""${ANONYMOUS}" -ne 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
     -XDELETE \
     ${RT_URL}/${DST_PATH}"
 
@@ -120,7 +121,7 @@ rt_list_directory() {
   ANONYMOUS="${2:-1}"
 
   _CMD="curl -s \
-    $( ([[ "${ANONYMOUS}" != 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
+    $( ([[ ""${ANONYMOUS}" -ne 1 ]] && echo " -u${RT_USER:?}:${RT_TOKEN:?}") || true) \
     -XGET \
     ${RT_URL}/api/storage/${DST_PATH}"