Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post: Introducing BMO e2e #536

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Post: Introducing BMO e2e #536

merged 1 commit into from
Dec 17, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 13, 2024 •
edited
Loading

Add a blog post introducing the BMO e2e suite.

Fixes: #371

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit ae4756f
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/67612e8f56488a0008b3d228
😎 Deploy Preview https://deploy-preview-536--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lentzi90
Copy link
Member Author

/cc @kashifest @tuminoid

tuminoid
tuminoid reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits and suggestions.

Good post about the problem and solution, which has made much easier and is showing a way for other repos to adapt as well.

_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Outdated Show resolved Hide resolved
_posts/2024-12-12-Introducing-BMO-E2E.md Show resolved Hide resolved
Rozzii
Rozzii reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/post-introducing-bmo-e2e branch from 0092882 to 8f118f1 Compare December 16, 2024 10:48
@lentzi90
Copy link
Member Author

Oh come on! What is the logic that determines how that cspell file should be formatted? It seems to change all the time

@lentzi90 lentzi90 force-pushed the lentzi90/post-introducing-bmo-e2e branch from 8f118f1 to ed5b59a Compare December 16, 2024 10:53
@tuminoid
Copy link
Member

Oh come on! What is the logic that determines how that cspell file should be formatted? It seems to change all the time

LOL, I had the same. Not sure what triggers it. At some point I reasoned to myself it is about line length but then it just decided to reformat it anyways in different way on next save.

@lentzi90
Post: Introducing BMO e2e
ae4756f 
Add a blog post introducing the BMO e2e suite.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/post-introducing-bmo-e2e branch from ed5b59a to ae4756f Compare December 17, 2024 07:55
@lentzi90 lentzi90 requested a review from tuminoid December 17, 2024 07:59
tuminoid
tuminoid reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Remember to promote the post in the baremetal slack.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@metal3-io-bot metal3-io-bot merged commit 89a6e3e into metal3-io:source Dec 17, 2024
10 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/post-introducing-bmo-e2e branch December 17, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@zaneb zaneb Awaiting requested review from zaneb

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BMO e2e introduction blog post
4 participants
@lentzi90 @metal3-io-bot @tuminoid @Rozzii