Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Salima's blog post on Jekyll #389

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 22, 2024

This included #388 with the necessary fixes to make pre-commit happy.

Author: @SafeEHA eemarabs@gmail.com

Signed-off-by: SafeEHA <eemarabs@gmail.com>

Article on How to run Metal3 website locally with Jekyll

Signed-off-by: SafeEHA <eemarabs@gmail.com>

Article on How to run Metal3 website locally with Jekyll

Signed-off-by: SafeEHA <eemarabs@gmail.com>

precommit fixes

Signed-off-by: SafeEHA <eemarabs@gmail.com>

precommit fixes

Signed-off-by: SafeEHA <eemarabs@gmail.com>

precommit fixes

Signed-off-by: SafeEHA <eemarabs@gmail.com>
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit b44dc79
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/65ae601435c7e30008a7ff0e
😎 Deploy Preview https://deploy-preview-389--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2024
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/jekyll-blog-post branch from 5a91d39 to b44dc79 Compare January 22, 2024 12:31
@tuminoid tuminoid changed the title WIP: add Salima's blog post on Jekyll add Salima's blog post on Jekyll Jan 23, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
@tuminoid
Copy link
Member Author

/cc @lentzi90 @Rozzii

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit dd712d5 into metal3-io:source Jan 23, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/jekyll-blog-post branch January 23, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants