Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove release 1.5 from test matrix #467

Merged
merged 1 commit into from
Sep 13, 2024
Merged

🌱 Remove release 1.5 from test matrix #467

merged 1 commit into from
Sep 13, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 28, 2024 •
edited
Loading

This PR removes tests related to CAPM3 branch release-1.5 in the test matrix

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2024
kashifest
kashifest reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Please update the title accordingly

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 28, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from fef8cbf to a5515f1 Compare August 30, 2024 05:34
tuminoid
tuminoid reviewed Aug 30, 2024
View reviewed changes
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch 2 times, most recently from 8a1676b to 20ce1d8 Compare August 30, 2024 05:45
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch 3 times, most recently from 9baf4cd to 77205de Compare August 30, 2024 05:47
@mquhuy mquhuy mentioned this pull request Sep 2, 2024
Closed
50 tasks
@mquhuy
Copy link
Member Author

mquhuy commented Sep 4, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 4, 2024

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from 77205de to 0a18e57 Compare September 5, 2024 07:25
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from 0a18e57 to 101c9a9 Compare September 5, 2024 07:25
tuminoid
tuminoid reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On L67, remove release-23.1

@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from 101c9a9 to cc94f1e Compare September 9, 2024 09:20
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from cc94f1e to 5e5b631 Compare September 9, 2024 09:23
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
tuminoid
tuminoid reviewed Sep 9, 2024
View reviewed changes
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch 3 times, most recently from 9542a95 to 936d341 Compare September 10, 2024 12:46
tuminoid
tuminoid reviewed Sep 10, 2024
View reviewed changes
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from 936d341 to 4acf171 Compare September 12, 2024 11:19
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2024
@mquhuy
Remove release-1.5 from test matrix
118cb9d 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-from-test-matrix branch from 4acf171 to 118cb9d Compare September 12, 2024 11:26
tuminoid
tuminoid reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2024
@metal3-io-bot metal3-io-bot merged commit 4a6fcc2 into metal3-io:main Sep 13, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/remove-release-1.5-from-test-matrix branch September 13, 2024 05:31
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
@Rozzii Rozzii mentioned this pull request Jan 24, 2025
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @tuminoid @kashifest