-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-1.7 support #413
Conversation
b102a18
to
5b3ef2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5b3ef2f
to
96757bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm cancel |
I have approved it already, please someone else take a look |
/lgtm |
@@ -83,16 +86,16 @@ The table describes which branches/image-tags are tested in each periodic CI tes | |||
| ------------------------------------------------ | ------------ | ----------- | -------------- | -------------- | ----------- | ---------- | | |||
| daily_main_integration_test_ubuntu/centos | main | main | main | latest | latest | latest | | |||
| daily_main_e2e_integration_test_ubuntu/centos | main | main | main | latest | latest | latest | | |||
| daily_release-1-7_integration_test_ubuntu/centos | release-1.7 | release-1.7 | release-0.6 | v0.6.0 | latest | latest | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table seems outdated we are now using e2e tests as main tests can we update the table before merging the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the job naming also changed recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Does it look ok now?
Signed-off-by: Huy Mai <huy.mai@est.tech>
96757bf
to
90e3dff
Compare
/lgtm |
/unhold |
/hold