Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump markdownlint to 0.13.0 #369

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 1, 2023

Bump markdownlint to 0.13.0.

Also, rewrite the rule config to ignore the issues instead of listing the allowed ones. Makes it clearer and more futureproof. Actual fixing of the issues should be done in some future commit.

TODO: bump in project-infra when all repos are bumped.

/hold
until metal3-io/project-infra#600 is merged, so the rule config is actually tested.

Bump markdownlint to 0.13.0.

Also, rewrite the rule config to ignore the issues instead of listing
the allowed ones. Makes it clearer and more futureproof. Actual fixing
of the issues should be done in some future commit.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/retest
To activate the markdownlint check when changing the script itself added in Prow.
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii December 1, 2023 09:56
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit dc8e8a6 into metal3-io:main Dec 1, 2023
3 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-markdownlint branch December 1, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants