-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for release-1.9 #1485
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 1.6 as well?
We have agreed to follow best practice of not mixing adding and removing in same PR. There |
Did we? I am fine either ways, IMHO the removal in the same PR makes more sense so as to we dont forget |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes. They make diffs harder to read, and also sometimes contain unrelated stuff. Makes also reverting impossible and also referring to PRs from other PRs or isssues obscure as it is not clear from the title/changes. Also timing for adding and removing might be different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
Let's see about this chicken and egg issue with this and metal3-io/cluster-api-provider-metal3#2164 |
Add support for release-1.9. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
4df88b2
to
46c786b
Compare
/test metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main |
/override metal3-dev-env-integration-test-ubuntu-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-dev-env-integration-test-ubuntu-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/unhold |
This needs to go in manually unfortunately, issue is we hard code 1.x.99 for main branch in dev-env which is non existent in capm3 and for capm3 to pass the test dev-env now needs to know this. |
Add support for release-1.9.