Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for release-1.9 #1485

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

tuminoid
Copy link
Member

Add support for release-1.9.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@tuminoid
Copy link
Member Author

/hold
Until we have releases done and JJBs https://gerrit.nordix.org/c/infra/cicd/+/22800 etc

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1.6 as well?

@tuminoid
Copy link
Member Author

tuminoid commented Dec 18, 2024

Remove 1.6 as well?

We have agreed to follow best practice of not mixing adding and removing in same PR. There is will be another PR for removals.

@kashifest
Copy link
Member

We have agreed to follow best practice of not mixing adding and removing in same PR. There is will be another PR for removals.

Did we? I am fine either ways, IMHO the removal in the same PR makes more sense so as to we dont forget
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@tuminoid
Copy link
Member Author

We have agreed to follow best practice of not mixing adding and removing in same PR. There is will be another PR for removals.

Did we? I am fine either ways, IMHO the removal in the same PR makes more sense so as to we dont forget /approve

Yes. They make diffs harder to read, and also sometimes contain unrelated stuff. Makes also reverting impossible and also referring to PRs from other PRs or isssues obscure as it is not clear from the title/changes. Also timing for adding and removing might be different.

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
@tuminoid
Copy link
Member Author

Let's see about this chicken and egg issue with this and metal3-io/cluster-api-provider-metal3#2164

Add support for release-1.9.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
@tuminoid
Copy link
Member Author

/override metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@kashifest
Copy link
Member

This needs to go in manually unfortunately, issue is we hard code 1.x.99 for main branch in dev-env which is non existent in capm3 and for capm3 to pass the test dev-env now needs to know this.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@metal3-io-bot metal3-io-bot merged commit 1bdb415 into metal3-io:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants