Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fixing CAPM3RELEASE for main branch #1452

Merged
merged 1 commit into from
Aug 30, 2024
Merged

🌱 Fixing CAPM3RELEASE for main branch #1452

merged 1 commit into from
Aug 30, 2024

Conversation

adilGhaffarDev
Copy link
Member

Fixing CAPM3RELEASE to point to main for main branch tests

@adilGhaffarDev
Fixing CAPM3RELEASE for main branch
ea1f681 
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2024
tuminoid
tuminoid reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-8

@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-8
just ran it to fix branch protection

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8

In response to this:

/override metal3-centos-e2e-integration-test-release-1-8
just ran it to fix branch protection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/hold
There is discussion about the 1.9.99 in CAPM3 PR.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
smoshiur1237
smoshiur1237 reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@adilGhaffarDev
Copy link
Member Author

once this: metal3-io/cluster-api-provider-metal3#1938 merged metal3-centos-e2e-integration-test-release-1-8 test will pass.

@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main
/unhold
This goes in first and then we can merge capm3 PRs.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8, metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main
/unhold
This goes in first and then we can merge capm3 PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit eb6a01c into metal3-io:main Aug 30, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the ci-fix-1.8/adil branch August 30, 2024 08:30
@adilGhaffarDev adilGhaffarDev mentioned this pull request Sep 2, 2024
Closed
50 tasks
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
@Rozzii Rozzii mentioned this pull request Jan 24, 2025
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@mboukhalfa mboukhalfa mboukhalfa left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adilGhaffarDev @metal3-io-bot @tuminoid @mboukhalfa @smoshiur1237