🌱 Take Deploy-cli to replace deploy.sh #1447
Conversation
metal3-io-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/S
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
from
50f68c9 to
62479c0
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
metal3-io-bot
added
the
do-not-merge/work-in-progress
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/retest |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/retest |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/retest |
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
from
62479c0 to
36505c0
Compare
|
Deploy-CLI was merged. Repurposing this PR as adaptation of the new tool to dev-env. /retitle 🌱 Take Deploy-cli to replace deploy.sh |
metal3-io-bot
changed the title
|
/test metal3-dev-env-integration-test-ubuntu-main |
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
4 times, most recently
from
6f9b837 to
5c22adb
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/retest-required |
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
from
5c22adb to
9210083
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
from
9210083 to
4e4db6a
Compare
metal3-io-bot
added
size/S
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
02_configure_host.sh
Outdated
| # if it's available, and use deploy.sh otherwise. | ||
|
|
||
| pushd "${BMOPATH}" | ||
| make deploy-cli && chmod +x tools/bin/deploy-cli && rm tools/deploy.sh && cp tools/bin/deploy-cli tools/deploy.sh |
There was a problem hiding this comment.
What happens when we run this in BMO 0.8 or older? It will just exit the script with failure?
There was a problem hiding this comment.
There is a lesson to be learned here, just don't know what lesson that would be. This definitely should exit, as there is "set -e", make is returning 2 for failure, and && does not trigger pipefail shenanigans.
Anyways, let's write it properly, ie.
| make deploy-cli && chmod +x tools/bin/deploy-cli && rm tools/deploy.sh && cp tools/bin/deploy-cli tools/deploy.sh | |
| pushd "${BMOPATH}" | |
| if make deploy-cli; then | |
| chmod +x tools/bin/deploy-cli | |
| cp tools/bin/deploy-cli tools/deploy.sh | |
| fi | |
| popd |
Now that we have deploy-cli in BMO main, we can start using it to replace deploy.sh in installing BMO and Ironic. Signed-off-by: Huy Mai <huy.mai@est.tech>
mquhuy
force-pushed
the
mquhuy/test-deploy-cli
branch
from
4e4db6a to
04f84c8
Compare
|
/test metal3-centos-e2e-integration-test-release-1-8 |
| pushd "${BMOPATH}" | ||
| if make deploy-cli; then | ||
| chmod +x tools/bin/deploy-cli | ||
| rm tools/deploy.sh |
There was a problem hiding this comment.
We don't need to delete it, we copy over it on next line.
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/test metal3-centos-e2e-integration-test-release-1-9 |
|
/retest |
1 similar comment
|
/retest |
|
@mquhuy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mquhuy: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR is currently used to test metal3-io/baremetal-operator#1669 Eventually we could consider merging it (to use deploy-cli in CI), but for now let's holdThis PR takes Deploy-cli into use to replace deploy.sh in dev-env deployment and tests.