Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 bump k8s to v1.31.0 #1444

Merged
merged 1 commit into from
Aug 15, 2024
Merged

🌱 bump k8s to v1.31.0 #1444

merged 1 commit into from
Aug 15, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Aug 2, 2024 •
edited
Loading

  • bump k8s to v1.31.0
  • KIND_VERSION to v0.23.0
  • KIND_NODE_IMAGE_VERSION to v1.30.0

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2024
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the uplift-k8s-1.31.0-rc.0/adil branch from d67f393 to b2cfadf Compare August 2, 2024 13:40
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the uplift-k8s-1.31.0-rc.0/adil branch 2 times, most recently from 4e05b79 to 175748e Compare August 6, 2024 12:53
@adilGhaffarDev adilGhaffarDev force-pushed the uplift-k8s-1.31.0-rc.0/adil branch from 175748e to dfbb8c9 Compare August 14, 2024 10:08
@adilGhaffarDev adilGhaffarDev changed the title 🌱 bump k8s to v1.31.0-rc.0 🌱 bump k8s to v1.31.0 Aug 14, 2024
tuminoid
tuminoid reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

@adilGhaffarDev
Copy link
Member Author

we don't have 1.31 image on artifactory yet that's why it's failing.

@tuminoid
Copy link
Member

we don't have 1.31 image on artifactory yet that's why it's failing.

Where does the image come from? Manual?

@adilGhaffarDev
Copy link
Member Author

Where does the image come from? Manual?

jenkins job should push it, but seems like it didn't work, @Sunnatillo has pushed them manually.

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member

Can you update renovate.json as well like in here?
Nordix@f7c2c40#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57

Lets wait for the tests to pass before doing the change. We can just override them.

@adilGhaffarDev adilGhaffarDev force-pushed the uplift-k8s-1.31.0-rc.0/adil branch from dfbb8c9 to 1a18db1 Compare August 15, 2024 08:09
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2024
@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@adilGhaffarDev
bump k8s to v1.31.0
c00021b 
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev adilGhaffarDev force-pushed the uplift-k8s-1.31.0-rc.0/adil branch from 1a18db1 to c00021b Compare August 15, 2024 08:11
@adilGhaffarDev
Copy link
Member Author

Can you update renovate.json as well like in here?
Nordix@f7c2c40#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57

done

@Sunnatillo
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sunnatillo
Sunnatillo reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-dev-env-integration-test-ubuntu-main

Per comment above, only renovate was changed after tests had passed.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7, metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7
/override metal3-dev-env-integration-test-ubuntu-main

Per comment above, only renovate was changed after tests had passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 892c508 into metal3-io:main Aug 15, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift-k8s-1.31.0-rc.0/adil branch August 15, 2024 08:19
@adilGhaffarDev adilGhaffarDev mentioned this pull request Sep 2, 2024
Closed
50 tasks
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
@Rozzii Rozzii mentioned this pull request Jan 24, 2025
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adilGhaffarDev @metal3-io-bot @tuminoid @Sunnatillo