Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add release-1.8-branch-config #1443

Merged
merged 1 commit into from
Aug 29, 2024
Merged

🌱 Add release-1.8-branch-config #1443

merged 1 commit into from
Aug 29, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 1, 2024

No description provided.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2024
@mquhuy mquhuy changed the title :seediAdd-release-1.8-branch-config 🌱 Add release-1.8-branch-config Aug 1, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 1, 2024

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
smoshiur1237
smoshiur1237 reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
tuminoid
tuminoid reviewed Aug 5, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.8-branch-config branch from 2be2b81 to bc2993d Compare August 27, 2024 11:03
@tuminoid
Copy link
Member

Can we do removing 1.5 and adding 1.8 in separate PRs please?

@mquhuy mquhuy force-pushed the mquhuy/add-release-1.8-branch-config branch from bc2993d to d81e4c3 Compare August 28, 2024 09:00
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
tuminoid
tuminoid reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [smoshiur1237,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mquhuy mquhuy mentioned this pull request Aug 28, 2024
Merged
@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

/test metal3-centos-e2e-integration-test-release-1-7
/test metal3-dev-env-integration-test-ubuntu-main

@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

@tuminoid Could you please change to /lgtm?

kashifest
kashifest reviewed Aug 28, 2024
View reviewed changes
lib/common.sh Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.8-branch-config branch from d81e4c3 to a90a6ff Compare August 28, 2024 11:19
kashifest
kashifest reviewed Aug 28, 2024
View reviewed changes
lib/common.sh Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.8-branch-config branch from a90a6ff to 6f329c4 Compare August 28, 2024 11:24
tuminoid
tuminoid reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the commit points to RC, the tags should too. They cannot point to different things, especially to ones that do not exist.

lib/common.sh Outdated Show resolved Hide resolved
lib/common.sh Outdated Show resolved Hide resolved
@mquhuy
Add-release-1.8-branch-config
5936aad 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.8-branch-config branch from 6f329c4 to 5936aad Compare August 29, 2024 07:19
tuminoid
tuminoid reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
smoshiur1237
smoshiur1237 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7, metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 37c1261 into metal3-io:main Aug 29, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-release-1.8-branch-config branch August 29, 2024 10:26
@adilGhaffarDev adilGhaffarDev mentioned this pull request Sep 2, 2024
Closed
50 tasks
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
@Rozzii Rozzii mentioned this pull request Jan 24, 2025
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mquhuy @tuminoid @metal3-io-bot @kashifest @smoshiur1237