Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minikube the default ephemeral cluster #1404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make minikube the default ephemeral cluster #1404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,7 @@ export KUBERNETES_BINARIES_VERSION="${KUBERNETES_BINARIES_VERSION:-${KUBERNETES_
export KUBERNETES_BINARIES_CONFIG_VERSION=${KUBERNETES_BINARIES_CONFIG_VERSION:-"v0.15.1"}

# Ephemeral Cluster
if [[ "${CONTAINER_RUNTIME}" = "docker" ]]; then
export EPHEMERAL_CLUSTER=${EPHEMERAL_CLUSTER:-"kind"}
else
export EPHEMERAL_CLUSTER="minikube"
fi
export EPHEMERAL_CLUSTER="minikube"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export EPHEMERAL_CLUSTER="minikube"
export EPHEMERAL_CLUSTER=${EPHEMERAL_CLUSTER:-"minikube"}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ow yeah, this I did intentionally here for the test because it gets dictated from different places like project-infra. CAPM3 etc


# Kubectl version (do not forget to update KUBECTL_SHA256 when changing KUBERNETES_VERSION!)
export KUBECTL_VERSION="${KUBECTL_VERSION:-${KUBERNETES_BINARIES_VERSION}}"
Expand Down