Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release-1.7 branch config for CAPM3 and IPAM #1381

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add release-1.7 branch config for CAPM3 and IPAM #1381

merged 1 commit into from
Apr 25, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 12, 2024

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch from 5017522 to 83f8e5c Compare April 12, 2024 13:24
@adilGhaffarDev adilGhaffarDev mentioned this pull request Apr 12, 2024
Closed
12 tasks
tuminoid
tuminoid reviewed Apr 16, 2024
View reviewed changes
lib/common.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch 2 times, most recently from b42cf86 to 7762d31 Compare April 18, 2024 08:44
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
kashifest
kashifest reviewed Apr 19, 2024
View reviewed changes
lib/common.sh Show resolved Hide resolved
lib/common.sh Show resolved Hide resolved
lib/releases.sh Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch from 7762d31 to 190d5d0 Compare April 19, 2024 08:36
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch from 190d5d0 to 4f79a61 Compare April 19, 2024 08:36
@mquhuy
Add support for release 1.7
2e92e4a 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch from 4f79a61 to 2e92e4a Compare April 19, 2024 08:39
Sunnatillo
Sunnatillo reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
kashifest
kashifest reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@adilGhaffarDev
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@adilGhaffarDev
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main

/test-centos-integration-release-1-6

@tuminoid
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main
/test-centos-integration-release-1-6

@tuminoid
Copy link
Member

/hold
for tide conflict, unhold when tests passed

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/hold
tide is not cooperating at all.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-6
/unhold
Prow and GH branch protection mismatched.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid
Copy link
Member

/test-centos-integration-release-1-7

@tuminoid
Copy link
Member

/test-centos-integration-release-1-7
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@tuminoid tuminoid mentioned this pull request Apr 25, 2024
Merged
@metal3-io-bot metal3-io-bot merged commit 0f7cb7b into metal3-io:main Apr 25, 2024
7 of 8 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-release-1.7 branch April 25, 2024 08:03
@adilGhaffarDev adilGhaffarDev mentioned this pull request Aug 13, 2024
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mquhuy @metal3-io-bot @adilGhaffarDev @tuminoid @Sunnatillo @kashifest