Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix runlogwatch failure if LOG_DIR does not exist #618

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

elfosardo
Copy link
Member

Fixes #617

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2025
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo elfosardo force-pushed the fix-runlogwatch-exits branch from b0fa292 to dc60eca Compare February 4, 2025 14:31
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@elfosardo
Copy link
Member Author

/cc @dtantsur

@dtantsur
Copy link
Member

dtantsur commented Feb 6, 2025

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@metal3-io-bot metal3-io-bot merged commit 1f44fb7 into metal3-io:main Feb 6, 2025
5 of 6 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runlogwatch fails and stops if LOG_DIR does not exist
4 participants