Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 bump markdownlint-cli2 to v0.12.0 #575

Merged
merged 1 commit into from
Oct 4, 2024
Merged

🌱 bump markdownlint-cli2 to v0.12.0 #575

merged 1 commit into from
Oct 4, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Oct 3, 2024

Bump markdownlint-cli2 linter to v0.12.0, which contains markdownlint-cli2 tool v0.14.0, with plenty of fixes.

No local fixes needed.

@tuminoid
bump markdownlint-cli2 to v0.12.0
89cee0d 
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/hold
Needs project-infra bump first.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/cherry-pick release-26.0

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-26.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-26.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/cherry-pick release-25.0

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-25.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-25.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/cherry-pick release-24.1

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-24.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-24.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

tuminoid commented Oct 3, 2024

/cherry-pick release-24.0

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-24.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-24.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 4, 2024

/unhold
Project-infra PR was merged, this is now getting tested with new version.
/test markdownlint

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 4, 2024

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii October 4, 2024 07:50
@tuminoid
Copy link
Member Author

tuminoid commented Oct 4, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rozzii
Rozzii reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@metal3-io-bot metal3-io-bot merged commit 8e09962 into metal3-io:main Oct 4, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-markdownlint-cli2 branch October 4, 2024 09:30
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #576

In response to this:

/cherry-pick release-26.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Oct 4, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #577

In response to this:

/cherry-pick release-25.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Oct 4, 2024
Merged
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #578

In response to this:

/cherry-pick release-24.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #579

In response to this:

/cherry-pick release-24.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @elfosardo @Rozzii