Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Pin setuptools during image build #573

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

elfosardo
Copy link
Member

Usually the setuptools installed by the system is stable but a bit too old compared to the packages we use for ironic, so pinning a more recent version helps avoiding errors and incompatibilities.

Signed-off-by: Riccardo Pittau elfosardo@gmail.com
(cherry picked from commit 82692ba)

Usually the setuptools installed by the system is stable but a bit
too old compared to the packages we use for ironic, so pinning a
more recent version helps avoiding errors and incompatibilities.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
(cherry picked from commit 82692ba)
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2024
@elfosardo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-release-1-7 metal3-centos-e2e-integration-test-release-1-7

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@derekhiggins
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@metal3-io-bot metal3-io-bot merged commit 12cad12 into metal3-io:release-24.1 Sep 25, 2024
8 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Oct 2, 2024
OCPBUGS-37365: Update log statement to avoid logging entire node object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants