Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "pin ironic source" #560

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

tuminoid
Copy link
Member

This reverts commit 9443d08.

Revert temporary fix, when the real bugfix has landed in Ironic's repository.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
This reverts commit 9443d08.

Revert temporary fix, when the same bugfix has landed in Ironic's
repository.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/revert-temporary-bugfix branch from 475bf2e to 06c0c63 Compare September 11, 2024 15:06
@tuminoid
Copy link
Member Author

/cc @dtantsur @Rozzii

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@dtantsur
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/unhold

Upstream fix is merged.
/cc @dtantsur

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/retest
Flake

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@metal3-io-bot metal3-io-bot merged commit 935daa7 into metal3-io:main Sep 13, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/revert-temporary-bugfix branch September 13, 2024 11:22
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 16, 2024
OCPBUGS-38782: redfish-virtualmedia fails on XFusion nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants