Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Pin ironic source #559

Merged
merged 1 commit into from
Sep 11, 2024
Merged

🐛 Pin ironic source #559

merged 1 commit into from
Sep 11, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Sep 11, 2024

Workaround to unblock the CI.

This commit:

  • Pins the Ironic source to a WIP upstream gerrit change that resolves a regression introduced by a recent change.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Sep 11, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

dtantsur
dtantsur reviewed Sep 11, 2024
View reviewed changes
ironic-source-list Outdated Show resolved Hide resolved
@Rozzii Rozzii force-pushed the pin-ironic-source branch 2 times, most recently from da72401 to 75d9d9b Compare September 11, 2024 12:00
@Rozzii
pin ironic source
9443d08 
Workaround to unblock the CI.

This commit:
- Pins the Ironic source to a WIP upstream gerrit change that resolves
a regression introduced by a recent change.

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@Rozzii
Copy link
Member Author

Rozzii commented Sep 11, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/retest
Flake

@dtantsur
Copy link
Member

/approve

Let's remember to revert it as soon as possible.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
tuminoid
tuminoid reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@tuminoid
Copy link
Member

/retest
Network flake

@tuminoid
Copy link
Member

Centos has passed the inspection, so this is a good fix 👍

@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main
Ubuntu is network flaking out, so I'm overriding so we can get the fix in.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
Ubuntu is network flaking out, so I'm overriding so we can get the fix in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

Once this merges, I will create revert PR to remind us to get rid of this, when the patch lands on upstream Ironic.

@metal3-io-bot metal3-io-bot merged commit 4232437 into metal3-io:main Sep 11, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the pin-ironic-source branch September 11, 2024 14:58
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 16, 2024
@openshift-merge-bot
Merge pull request metal3-io#559 from elfosardo/ocpbugs36492
0512ea1 
OCPBUGS-36492: Bump ironic-lib to fix utf8 decoding issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozzii @tuminoid @dtantsur @metal3-io-bot