Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛SQLITE: fix Write-Ahead Log option and file permissions #550

Merged
merged 1 commit into from
Sep 23, 2024
Merged

🐛SQLITE: fix Write-Ahead Log option and file permissions #550

merged 1 commit into from
Sep 23, 2024

Conversation

blallau
Copy link

@blallau blallau commented Aug 30, 2024

sqlite Write-Ahead Log option and file permissions are set a a file named "ironic.db", but Ironic file used by Ironic is "ironic.sqlite" as bellow.

ironic-config/ironic.conf.j2:
connection = sqlite:////var/lib/ironic/ironic.sqlite

Fixes #549

@metal3-io-bot
Copy link
Contributor

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2024
@blallau blallau changed the title SQLITE: fix Write-Ahead Log option and file permissions 🐛SQLITE: fix Write-Ahead Log option and file permissions Aug 30, 2024
tuminoid
tuminoid reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, good finding!

Please fix the sign-off of your commit to pass DCO check.

Dockerfile Outdated Show resolved Hide resolved
@tuminoid
Copy link
Member

tuminoid commented Sep 2, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2024
@blallau blallau force-pushed the fix549 branch 2 times, most recently from da82ee0 to 5575d57 Compare September 2, 2024 08:31
SQLITE: fix Write-Ahead Log option and file permissions
2692d51 
sqlite Write-Ahead Log option and file permissions are set on a file named "ironic.db",
but Ironic file used by Ironic is "ironic.sqlite" as bellow.

ironic-config/ironic.conf.j2:
connection = sqlite:////var/lib/ironic/ironic.sqlite

fix metal3-io#549

Signed-off-by: LALLAU Bertrand <blallau@github.com>
@tuminoid
Copy link
Member

tuminoid commented Sep 2, 2024

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@blallau
Copy link
Author

blallau commented Sep 3, 2024

@tuminoid CI fails on timeout :(
Can we trigger it another time ?

@tuminoid
Copy link
Member

tuminoid commented Sep 3, 2024

You can just /retest or trigger it again with the same command I used.

/retest

@tuminoid
Copy link
Member

tuminoid commented Sep 3, 2024

OK, CI for centos should now be working.

/retest

@blallau
Copy link
Author

blallau commented Sep 5, 2024

/retest

@tuminoid
Copy link
Member

tuminoid commented Sep 5, 2024

/retest

Retest re-triggers failed tests only. All tests have passed, it just needs approvals now.

@derekhiggins
Copy link
Member

/lgtm
thanks

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 5, 2024
@openshift-merge-bot
Merge pull request metal3-io#550 from iurygregory/OCPBUGS-38521
3d4e074 
OCPBUGS-38521: set min version for python3-webob
@tuminoid
Copy link
Member

/cc @dtantsur @elfosardo

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@metal3-io-bot metal3-io-bot merged commit b8a9a22 into metal3-io:main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write-Ahead Log option and file permissions are not set on SQLITE file
5 participants
@blallau @metal3-io-bot @tuminoid @derekhiggins @elfosardo